holochain / holochain-rust

DEPRECATED. The Holochain framework implemented in rust with a redux style internal state-model.
GNU General Public License v3.0
1.12k stars 267 forks source link

remove newrelic from holochain #2143

Closed zippy closed 4 years ago

zippy commented 4 years ago

PR summary

Removes new-relic building completely from conductor for now.

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

Connoropolous commented 4 years ago

what was newrelic there for, and why take it out?

zippy commented 4 years ago

what was newrelic there for, and why take it out?

We added it for debugging purposes to try and track down some cross-process problems with the tracing it offeres, however it's causing problems in our holoport build chain so we need to clean it out for now. In the "production" context rewrelic doesn't make any sense for holochain at all because it's centralized monitoring. It may make sense to add back into sim2h_server which is a centralized service so that it can be monitored.

freesig commented 4 years ago

This will need to be removed from holochain tracing aswell. Let's just put it the deps under a conditional compile and make the new relic a pass through so you don't need to comment all these out

zippy commented 4 years ago

obsolete