[x] an optimization of not querying the DHT for get links requests when we know that we are the DHT authority for the base of the query.
[x] two conductor fixes during error cases (like base hasn't arrived yet) in hold_aspects request:
stop incorrectly recording aspects as held
stop locking up the future
[x] because sim2h doesn't get error messages from a hold_aspect request it must also no longer records aspects sent in those messages as held, and thus the conductor must explicitly send back a list of aspects held after a hold_aspect request
[x] get authoring list doesn't really work because correct items won't be gossiped and the optimization now breaks this. Fix this by not responding with the list, and instead re-publishing.
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
[ ] if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
documentation
[ ] this code has been documented according to our docs checklist
PR summary
This PR adds:
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation