search

holochain / holochain

The current, performant & industrial strength version of Holochain on Rust.
https://holochain.org
Other
1.17k stars 141 forks source link

[BUG] Sending a message that doesn't deserialize to a Holochain websocket causes the connection to close #3679

Closed ThetaSinner closed 1 month ago

ThetaSinner commented 6 months ago

Describe the bug

Sending any message which doesn't deserialize (e.g. an app request to an admin interface websocket) will cause the connection to close.

Expected behavior

The connection stays open and ideally i get an error message back telling me what I did wrong.

Steps to reproduce

Modify any sweettest that sends websocket messages and swap out an app request for an admin request.

Any additional information

The use of futures::stream::unfold needs looking at. Any receive error will stop the stream but serialisation errors don't need to be fatal for the connection.

There should also be a test checking that this behaves correctly!

github-actions[bot] commented 5 months ago

This item has been open for 30 days with no activity.

github-actions[bot] commented 4 months ago

This item has been open for 30 days with no activity.