search

holochain / holoscape

A complete end-user deployment of a Holochain conductor with UI for administration and a run-time for hApp UIs
63 stars 8 forks source link

ws port config for custom bundles #58

Open nphias opened 4 years ago

nphias commented 4 years ago

so after adding our bundle to holoscape throught the UI wizard realized the links were hardcoded to a WS port. in the docs HOLOSCAPE_ADMIN_PORT 4436

changed the static files ws port to 4436 and it worked. in the bundle config file it would be nice if you could choose the websocket port for your happ later I realized that one can change the port in the condutor_config.toml in the relevant OS install directory. Its a post install task... which could be documented better

so i keep this issue open for a potential pre-install feature or for clearer documentation post install

marcusnewton commented 4 years ago

This can be fixed by removing the websocket url argument from hc-web-client. When you remove that argument, hc-web-client looks for the port specified in conductor-config.toml instead.

Connoropolous commented 4 years ago

I also find this is an under-documented thing.

Our acorn-ui project uses this configuration, where our webpack config adds a NODE_ENV distinction between 'development' and 'production' so that we can pass the right thing to our connect call, from hc-web-client. See: https://github.com/h-be/acorn-ui/blob/78006146562a4816a9a93f0119e3b7e5b15bce0c/src/index.js#L34-L40