search

holochain / lair

secret lair private keystore
Apache License 2.0
42 stars 11 forks source link

Whitespaces in file paths make lair fail and exit without message #99

Closed lucksus closed 2 years ago

lucksus commented 2 years ago

We store all our config and resources, including all Holochain related bits, in APP_DATA_PATH, which on macOS is under /Users/<username>/Library/Application Support/ and thus includes a space.

After we updated to 0.1.0 I just noticed lair just doesn't start on my mac, at least not in a production environment (works in tests on same machine where resources including lair config are put in our repo test directory without whitespace).

I played around with these paths in the config file:

pidFile: /Users/nicolasluck/Library/Application Support/ad4m/h/c/keystore/pid_file
storeFile: /Users/nicolasluck/Library/Application Support/ad4m/h/c/keystore/store_file

Tried escaping the space with a backslash and putting everything in quotes, but lair keeps crashing (well exiting with code 0) without output. Keeping everything the same but changing those paths to something without space makes it work.

Is there any other way lair needs those paths to be escaped? Or is this a bug?

guillemcordoba commented 2 years ago

Maybe this is the bug? https://github.com/holochain/lair/issues/90

lucksus commented 2 years ago

Looks like the same problem, but that fix got merged almost two months ago. So maybe a regression?

lucksus commented 2 years ago

Just realized that 0.1.0 is pretty old and that fix was merged in later. So I guess I just found an old bug that got fixed already. We just have to then also update to a new Holochain version which is in process. I will close this issue and reopen if the new version doesn't fixes it.