App Library displays most recently updated release, rather than highest version number

holochain / launcher-tauri

Desktop launcher to install and use Holochain apps locally

262 stars 21 forks source link

App Library displays most recently updated release, rather than highest version number #133

Open mattyg opened 1 year ago

mattyg commented 1 year ago

Describe the bug "Install New App" page displays the most recently updated release number, rather than highest versioned release number. I'm not sure if this is a launcher issue or devhub issue.

To Reproduce On DevHub

Publish hApp release with tag 'app-store-ready' and version 1.0
Publish hApp release with version 2.0
Click "Edit Release" on the 1.0 hApp release, then "Save Changes"

In Launcher

Click "Install New App" the displayed version will be 1.0

Expected behavior The highest version number is displayed in the "Install New App" page

Logs (my launcher log is 700+ MB, maybe just let me know if you need it)

Screenshots n/a

Desktop (please complete the following information):

OS: Ubuntu 22.04
Holochain Launcher Version: 0.9.0

Additional context n/a

matthme commented 1 year ago

It's a Launcher issue. It filters the releases currently by last updated. Ideally it would probably show all versions and you can choose the one you'd like to install from a dropdown or similar. Since versions are non-numeric (or rather it is up to the developer whether he makes them numeric because it's just a version "name"), it's not necessarily possible to reliably sort them depending on what developers choose to enter there. Soon the app store will be added as a layer between the DevHub and the launcher, containing meta data about apps. I think we will offer much more filtering options then.

mattyg commented 1 year ago

It's a Launcher issue. It filters the releases currently by last updated. Ideally it would probably show all versions and you can choose the one you'd like to install from a dropdown or similar. Since versions are non-numeric (or rather it is up to the developer whether he makes them numeric because it's just a version "name"), it's not necessarily possible to reliably sort them depending on what developers choose to enter there. Soon the app store will be added as a layer between the DevHub and the launcher, containing meta data about apps. I think we will offer much more filtering options then.

Awesome! Thanks for sharing the broader context.