holochain / launcher

Desktop launcher to install and use Holochain apps locally
262 stars 21 forks source link

Unable to install kangaroo app and launcher with same holochain version via linux .deb #218

Open mattyg opened 3 months ago

mattyg commented 3 months ago

Describe the bug image

To Reproduce

Expected behavior The installation should not fail, it should just skip / overwrite copying the holochain binary.

Desktop (please complete the following information): Ubuntu 22.10 holochain 0.2.6

matthme commented 3 months ago

Oh yes, I noticed that as well at some point. I'm actually not sure what's the right approach here. Skipping or overwriting seems problematic to me since the name of the binary alone does not tell you for example whether it may have been compiled with specific features (e.g. sqlite-encrypted which is the default by now though). The way I ended up "solving" this is that I named my holochain and lair binaries with a suffix derived from the app name... Also, that part of the code is provided by tauri, assumingly in its packaging step so it's not something that's explicitly defined that way in the launcher and it might therefore potentially require forking tauri which would be a bit of a pain to maintain.