holochain / n3h

nodejs implementation of holochain networking / p2p backend process
48 stars 7 forks source link

Windows n3h-0.0.13-alpha-win-x64.exe cannot produce version console log, breaking HC Conductor #103

Open Connoropolous opened 5 years ago

Connoropolous commented 5 years ago

This issue was uncovered and discussed here: https://github.com/holochain/holochain-rust/issues/1460

In terms of steps to reproduce...

  1. Be on windows
  2. Download https://github.com/holochain/n3h/releases/download/v0.0.13-alpha/n3h-0.0.13-alpha-win-x64.exe
  3. change directions to the folder its' downloaded into
  4. Try running n3h-0.0.13-alpha-win-x64.exe --version

What you'll see: no output What you should see: # n3h version: "v0.0.13-alpha" #

This affects holochain because this code: https://github.com/holochain/holochain-rust/blob/2f7f76273e653c46828a12eff64776b30ab9c0f7/net/src/ipc/n3h.rs#L153-L169 expects that log to be produced in order to consider it successfully installed and at the right version.

The solution could equally well be to change how the Conductor expects it, because technically from what we can tell the binary actually 1. is downloaded fine, and 2. works fine

Solutions considered:

References:

ddd-mtl commented 5 years ago

when doing n3h-0.0.13-alpha-win-x64.exe --version --enable-logging A window pops up and shows the correct version number, but it doesn't output it in console. I believe thats why the version checking doesn't work on windows. Maybe there is an option in electron to build a console exe and not a windowed one? @neonphog

ddd-mtl commented 5 years ago

Quick workaround could be to skip the version checking on windows.