Fix meta handling in hackmode

holochain / n3h

nodejs implementation of holochain networking / p2p backend process

48 stars 7 forks source link

Fix meta handling in hackmode #95

Closed lucksus closed 5 years ago

lucksus commented 5 years ago

I'm not sure when this regression was introduced but after updating my local n3h and the branches I was working on (mainly the IPv6 branch) to master, I stopped seeing core receiving FetchMetaResults. I could verify that this is happening with vanilla n3h master and holochain-rust develop.

I found out that n3h was always trying to send that result to a remote node and never returning it back to core. This fixes that.

neonphog commented 5 years ago

Yeah, after digging in further, there are only two cases where core should send a handleFetchMetaResult to n3h:

n3h itself is requesting data
another peer is requesting data

there shouldn't be any reason to send the fetchMetaResult back over the ipc from this node.