search

holochain / tryorama

Toolset to manage Holochain conductors and facilitate test scenarios
212 stars 13 forks source link

Add support for bundles #71

Closed zippy closed 3 years ago

timotree3 commented 3 years ago

Build is hanging because holochain version isn't compiling successfully

pospi commented 3 years ago

Looks like some build errors internally generating malformed JS code. I only got some truncated snippets of the error from the tryorama prepare output but this may help-

│ src/config/spawn.ts(148,31): error TS1109: Expression expe
│ src/config/spawn.ts(148,46): error TS1109: Expression expe
│ src/config/spawn.ts(148,52): error TS1005: ':' expected.
│ src/index.ts(2,14): error TS2742: The inferred type of 'Co
│ src/logger.ts(12,14): error TS2742: The inferred type of '

errors like this upon execution-

node_modules/@holochain/tryorama/lib/config/spawn.js:141
        onSignal: player.onSignal ? .bind(player) ?  ? null :  :  : ,

SyntaxError: Unexpected token '.'
    at Module._compile (internal/modules/cjs/loader.js:892:18)
timotree3 commented 3 years ago

@pospi What version of typescript are you using?

pospi commented 3 years ago

@pospi What version of typescript are you using?

That's a good question but probably not an issue unless the package isn't configured correctly. tsc should resolve firstly to the version linked as a dependency in the package (ie. if you have globals installed they should not interfere).

However the additional complexity is that I'm not sure what might be resolved in a nested setup where tsc is actually a sub-dependency of these packages.

I can tell you that tryorama has "typescript": "^3.9.7" specified but when I npm i in a fresh clone and then run npx tsc -v the output is Version 3.9.9. Is that the same as what you're getting?

Noting that this version seems to build successfully without errors.

pospi commented 3 years ago

Build still broken when using pnpm due to execution of the prepare script in @holochain/conductor-api. This leads to a non-zero exit code affecting app-level install commands with nondeterministic unfinished install behaviour.

The naive temporary fix allowing me to reference via git would be to ignore the error code but correct fix would be to update the tsconfig.json in that repo to ignore warnings from node_modules as the only errors being reported are from @msgpack/msgpack and jest-diff and not the conductor API itself.