search

holochain / tx5

Holochain WebRTC P2P Communication Ecosystem
Apache License 2.0
67 stars 7 forks source link

Bump pion to v4 #108

Open mattyg opened 1 month ago

mattyg commented 1 month ago

pion/transport v3.0.2 includes a fix (workaround?) for android 11+ -- previous versions cannot connect to network interfaces (unless you use a fork of golang which p2p-shipyard is doing currently)

The fix commit in pion/transport: https://github.com/pion/transport/commit/3ba6182e023088a6242d24493b39c41b182227b2

The original golang issue: https://github.com/golang/go/issues/40569

The current workaround used by p2p-shipyard: https://github.com/darksoil-studio/p2p-shipyard/blob/e53bca77507eb808009b753b811aa9fc8ed32f0a/nix/modules/custom-go-compiler.nix#L66

neonphog commented 1 month ago

@mattyg - We're on v3.2.24: https://github.com/holochain/tx5/blob/05e82a2da9aa1877731764ba2463bf5bcd2a261d/crates/tx5-go-pion-sys/go.mod#L7

Did you mean bump to v4? That just stabilized today apparently! https://pkg.go.dev/github.com/pion/webrtc/v4?tab=versions

mattyg commented 1 month ago

ah yes I guess I meant pion/transport v3.0.2 which is included in pion v4 -- so yeah that would be great to bump soon!