holodeck-b2b / Holodeck-B2B

Holodeck B2B is an AS4 system-to-system messaging solution that implements the OASIS specifications for ebMS3 and it's AS4 profile. For more information visit the project website
http://holodeck-b2b.org
GNU General Public License v3.0
68 stars 36 forks source link

OtherContentError (EBMS:0004) has recommended severity "failure" #141

Closed tigran-a closed 1 year ago

tigran-a commented 1 year ago

Hi,

By the ebms core spec the severity of EBMS:0004 should be "failure", while holodeckb2b uses as default "warning": https://github.com/holodeck-b2b/Holodeck-B2B/blob/73b5caf22ad04a965ef1874c12533523a726e63b/modules/holodeckb2b-core/src/main/java/org/holodeckb2b/common/errors/OtherContentError.java#L34

Thanks

sfieten commented 1 year ago

The recommended severity of the Other error indeed is failure. Because this error is used for situations where the other errors cannot be used it could also indicate a situation that could be resolved when a message is resent. This is indicated by severity level warning. Therefore we have decided to set the default severity for the Other error to this value.