search

holodeck-b2b / Holodeck-B2B

Holodeck B2B is an AS4 system-to-system messaging solution that implements the OASIS specifications for ebMS3 and it's AS4 profile. For more information visit the project website
http://holodeck-b2b.org
GNU General Public License v3.0
68 stars 36 forks source link

PModeFinder logs #146

Closed martan81 closed 2 months ago

martan81 commented 11 months ago

Debug logs in PModeFinder. It helps determine reason why P-Mode was not found.

RenateS commented 11 months ago

Thank you for your PR! Adding logging about P-Mode matching sounds like a good idea. We will review in detail and get back to you about including it in the next release.

sfieten commented 2 months ago

Hi Jozef, sorry for the late response, but I am just now looking at integrating this PR into the next version of HB2B. I think the new logging is a good addition to HB2B and will make it easier to debug P-Mode not found errors. So thank you for providing the code. I merged your code into the next version, I however also made two changes to it:

  1. Made the log owned by the PModeFinder class. So there no need to check if log exists. It also makes it easier to configure the logging as it can be enabled/disabled separately from the main message processing logging.
  2. Shortened the log messages by removed the P-Mode.id. For most log statements this results in logging of static strings, which is more efficient.