holodeck-b2b
commented
9 years ago Hi Philip,
thanks for the PR, seems like good improvements to me. Happy to merge them into the current branch. Just to make sure before I do, I assume you did try to build and run Holodeck B2B including these changes?
Regards Sander
sander@holodeck-b2b.org mailto:sander@holodeck-b2b.org http://www.holodeck-b2b.org http://www.holodeck-b2b.org/ http://nl.linkedin.com/in/sanderfieten
On 09 Sep 2015, at 11:36, Philip Helger notifications@github.com wrote:
Hi Sander! As promised some basic improvements on various placec. JavaDoc, coding style, POM dependencies etc. If you have any questions, don't hesitate to contact me. BR, Philip
You can view, comment on, or merge this pull request online at:
https://github.com/holodeck-b2b/Holodeck-B2B/pull/3 https://github.com/holodeck-b2b/Holodeck-B2B/pull/3 Commit Summary
Ignoring Eclipse project files Removed unused dependencies Fixed some minor JavaDoc and coding style issues Fixed some coding style and JavaDoc issues (but not all of them) removed Eclipse config files removed Eclipse config files File Changes
M .gitignore https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-0 (1) D .settings/org.eclipse.m2e.core.prefs https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-1 (4) A modules/holodeckb2b-common/.gitignore https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-2 (3) M modules/holodeckb2b-common/pom.xml https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-3 (124) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/as4/pmode/IReceptionAwareness.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-4 (4) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/general/IAgreement.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-5 (4) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/messagemodel/IErrorMessage.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-6 (2) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/messagemodel/IPayload.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-7 (3) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/messagemodel/util/compare.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-8 (72) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/pmode/ILeg.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-9 (2) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/pmode/IPMode.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-10 (2) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/submit/IMessageSubmitterFactory.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-11 (6) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/util/Interval.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-12 (24) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/util/KeyValuePair.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-13 (2) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/util/Utils.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-14 (20) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/workerpool/AbstractWorkerTask.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-15 (4) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/workerpool/IWorkerConfiguration.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-16 (2) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/workerpool/WorkerPool.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-17 (9) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/workerpool/xml/XMLWorkerConfig.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-18 (2) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/workers/DirWatcher.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-19 (2) M modules/holodeckb2b-common/src/main/java/org/holodeckb2b/common/workers/PathWatcher.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-20 (4) M modules/holodeckb2b-common/src/test/java/org/holodeckb2b/common/workerpool/WorkerPoolTest.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-21 (2) M modules/holodeckb2b-common/src/test/java/org/holodeckb2b/common/workerpool/XMLWorkerPoolConfigTest.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-22 (5) M modules/holodeckb2b-common/src/test/java/org/holodeckb2b/common/workers/DirWatcherTest.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-23 (2) M modules/holodeckb2b-common/src/test/java/org/holodeckb2b/common/workers/FileWatcherTest.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-24 (1) A modules/holodeckb2b-core/.gitignore https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-25 (3) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/as4/compression/CompressionDataHandler.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-26 (16) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/as4/compression/CompressionHandler.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-27 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/as4/compression/DeCompressionFailure.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-28 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/as4/compression/GZIPCompressingInputStream.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-29 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/deliverymethod/file/FileDeliveryFactory.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-30 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/constants/SecurityConstants.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-31 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/handlers/inflow/ReadError.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-32 (4) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/handlers/inflow/ReadReceipt.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-33 (4) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/handlers/inflow/ReadUserMessage.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-34 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/handlers/inflow/SaveUserMsgAttachments.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-35 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/handlers/outflow/PrepareResponseMessage.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-36 (10) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/mmd/xml/PartyId.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-37 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/packaging/ErrorSignal.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-38 (27) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/packaging/MessageInfo.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-39 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/packaging/MessageProperties.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-40 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/packaging/PartProperties.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-41 (4) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/packaging/PartyInfo.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-42 (15) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/packaging/PayloadInfo.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-43 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/packaging/Property.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-44 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/packaging/PullRequest.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-45 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/packaging/Receipt.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-46 (13) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/packaging/SOAPEnv.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-47 (4) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/packaging/Schema.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-48 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/packaging/SignalMessage.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-49 (8) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/packaging/UserMessage.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-50 (8) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/persistent/dao/MessageUnitDAO.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-51 (6) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/persistent/general/Description.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-52 (8) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/persistent/general/PartyId.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-53 (10) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/persistent/general/Property.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-54 (12) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/persistent/general/SchemaReference.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-55 (6) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/persistent/general/Service.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-56 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/persistent/general/TradingPartner.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-57 (14) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/persistent/message/MessageUnit.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-58 (6) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/persistent/message/Payload.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-59 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/persistent/message/Receipt.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-60 (6) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/persistent/message/UserMessage.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-61 (4) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/ebms3/util/PModeFinder.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-62 (4) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/pmode/impl/BusinessInfo.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-63 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/pmode/impl/PMode.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-64 (3) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/pmode/impl/PartyId.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-65 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/security/handlers/ProcessWSSHeaders.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-66 (2) M modules/holodeckb2b-core/src/main/java/org/holodeckb2b/security/util/SecurityUtils.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-67 (4) M modules/holodeckb2b-core/src/test/java/org/holodeckb2b/ebms3/pulling/PullConfigurationTest.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-68 (6) M modules/holodeckb2b-core/src/test/java/org/holodeckb2b/pmode/impl/AgreementTest.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-69 (3) M modules/holodeckb2b-core/src/test/java/org/holodeckb2b/pmode/impl/DeliverySpecificationTest.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-70 (3) M modules/holodeckb2b-core/src/test/java/org/holodeckb2b/pmode/impl/LegTest.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-71 (3) M modules/holodeckb2b-core/src/test/java/org/holodeckb2b/pmode/impl/PModeIdTest.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-72 (3) M modules/holodeckb2b-core/src/test/java/org/holodeckb2b/pmode/impl/ProtocolTest.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-73 (3) M modules/holodeckb2b-core/src/test/java/org/holodeckb2b/pmode/impl/ReceptionAwarenessTest.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-74 (7) M modules/holodeckb2b-core/src/test/java/org/holodeckb2b/pmode/impl/UserMessageFlowTest.java https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-75 (3) A modules/holodeckb2b-distribution/.gitignore https://github.com/holodeck-b2b/Holodeck-B2B/pull/3/files#diff-76 (2) Patch Links:
https://github.com/holodeck-b2b/Holodeck-B2B/pull/3.patch https://github.com/holodeck-b2b/Holodeck-B2B/pull/3.patch https://github.com/holodeck-b2b/Holodeck-B2B/pull/3.diff https://github.com/holodeck-b2b/Holodeck-B2B/pull/3.diff — Reply to this email directly or view it on GitHub https://github.com/holodeck-b2b/Holodeck-B2B/pull/3.
phax
Hi Sander! As promised some basic improvements on various placec. JavaDoc, coding style, POM dependencies etc. If you have any questions, don't hesitate to contact me. BR, Philip