holodex / app

http://holodex.enspiral.com
GNU Affero General Public License v3.0
24 stars 1 forks source link

enforce code style #40

Closed ahdinosaur closed 9 years ago

ahdinosaur commented 9 years ago

should we do it or not?

i'm starting to think maybe we should.

possible code styles:

simontegg commented 9 years ago

I've started doing new files with standard style. Its nice.

simontegg commented 9 years ago

Placeholder comment. Alongside js code style we have React patterns and best practices:

ahdinosaur commented 9 years ago

i reckon let's move to standard style as we churn code, i need to finish https://github.com/holodex/app/issues/40 before we can properly use the validator.

one discrepancy i've noticed in my person style: i prefer trailing commas. but hmm, maybe it's better to not have them, for example it's confusing when you can't put a trailing comma in

fn(
  arg1,
  arg2
)
``
ahdinosaur commented 9 years ago

at the end of #55, i moved us to be using standard. we should update the README with a standard badge.

ahdinosaur commented 9 years ago

done in 3519995fdfc2908ec3f6ba4c0753eaf183e05c68.