Closed simontegg closed 9 years ago
Ok fixed. I'll tidy this up, rebase and add some tests, but a look over is appreciated
such hacks :fireworks:, but if it works then that's great and looks good to me. also if you're based on master there's no reason to rebase, my mad science refactor-api
branch is in the stars right now. moving forward, i recommend we link up by each writing tests for our modules' desired interface.
@ahdinosaur Ok should be ready. Tests are token though.
hmm, i'm only seeing a blank screen on firefox and a mostly blank screen with arrows floating around on chrome.
check console. Are they <img>
's or <image>
's ?
I'm getting arrowheads + square images on firefox (no lines, no css clip: circle()
<img>
s. have you changed anything in your local react install that might separate yours from mine?
Yeah its in getMarkupWrap.js
. Need a little more jigging
patching done. Now fixing tests.
@ahdinosaur ok looking better now
looks good to me, sans some minor nitpicks. :palm_tree:
here's how it looks to me in firefox 35.0.1:
also the amount of hacks you've had to go through to get this to work is astounding, kudos to you @simontegg. :smile_cat:
My firefox is showing the arrowheads and `marker-end
?
Seems firefox doesn't support css clip-path: circle()
. I feel like that's a separate bug :)
I reckon this can be merged. I can do the firefox issues as a separate bug.
k cool, i'll merge it up, @simontegg can you file the issues?
deployed :tada:
Not ready to merge. This renders svg's by monkey patching
React.DOM
andSVGDOMPropertyConfig.Properties.