holodex / app

http://holodex.enspiral.com
GNU Affero General Public License v3.0
24 stars 1 forks source link

Bug/render nodes #49

Closed simontegg closed 9 years ago

simontegg commented 9 years ago

Not ready to merge. This renders svg 's by monkey patching React.DOM and SVGDOMPropertyConfig.Properties.

simontegg commented 9 years ago

Ok fixed. I'll tidy this up, rebase and add some tests, but a look over is appreciated

ahdinosaur commented 9 years ago

such hacks :fireworks:, but if it works then that's great and looks good to me. also if you're based on master there's no reason to rebase, my mad science refactor-api branch is in the stars right now. moving forward, i recommend we link up by each writing tests for our modules' desired interface.

simontegg commented 9 years ago

@ahdinosaur Ok should be ready. Tests are token though.

ahdinosaur commented 9 years ago

hmm, i'm only seeing a blank screen on firefox and a mostly blank screen with arrows floating around on chrome.

simontegg commented 9 years ago

check console. Are they <img>'s or <image>'s ?

simontegg commented 9 years ago

I'm getting arrowheads + square images on firefox (no lines, no css clip: circle()

ahdinosaur commented 9 years ago

<img>s. have you changed anything in your local react install that might separate yours from mine?

simontegg commented 9 years ago

Yeah its in getMarkupWrap.js. Need a little more jigging

simontegg commented 9 years ago

patching done. Now fixing tests.

simontegg commented 9 years ago

@ahdinosaur ok looking better now

ahdinosaur commented 9 years ago

looks good to me, sans some minor nitpicks. :palm_tree:

ahdinosaur commented 9 years ago

here's how it looks to me in firefox 35.0.1: wacky-holodex5

ahdinosaur commented 9 years ago

also the amount of hacks you've had to go through to get this to work is astounding, kudos to you @simontegg. :smile_cat:

simontegg commented 9 years ago

My firefox is showing the arrowheads and `marker-end?

Seems firefox doesn't support css clip-path: circle(). I feel like that's a separate bug :)

simontegg commented 9 years ago

I reckon this can be merged. I can do the firefox issues as a separate bug.

ahdinosaur commented 9 years ago

k cool, i'll merge it up, @simontegg can you file the issues?

ahdinosaur commented 9 years ago

deployed :tada: