holodex / app

http://holodex.enspiral.com
GNU Affero General Public License v3.0
24 stars 1 forks source link

refactor all the data things #55

Closed ahdinosaur closed 9 years ago

ahdinosaur commented 9 years ago

starting with the data structure changes described in openvocab/holodex#1, i rewrote most of the data-related code, a few times, plus i threw away most of the api code. it's not perfect, but it does what we need for now, and most importantly i've learned heaps about what we actually want for when i rewrite it some more.

close https://github.com/open-app/holodex/issues/13. close https://github.com/holodex/app/issues/48.

note: this PR is not ready to merge, but is getting close. i didn't intend for it to be such a large PR, but oh well, better luck next time.

ahdinosaur commented 9 years ago

woooo, i've finally reached feature parity with the current app after these changes! :balloon:

@simontegg would be nice to have a small bit of code review, at least to make sure this branch runs for you and that you support us merging it in to master and deploying to production. the code isn't ideal, but it's enough for us to keep on moving forward. cheers.

simontegg commented 9 years ago

Looks great.

ahdinosaur commented 9 years ago

deployed! :tada: