search

holodex / app

http://holodex.enspiral.com
GNU Affero General Public License v3.0
24 stars 1 forks source link

update node clip pathing #96

Closed ahdinosaur closed 9 years ago

ahdinosaur commented 9 years ago
ahdinosaur commented 9 years ago

no longer does "don't clip for groups (close https://github.com/open-app/holodex/issues/53)"

@simontegg good to merge?

simontegg commented 9 years ago

I'm still getting squares on people sometimes in firefox

simontegg commented 9 years ago

ahdinosaur commented 9 years ago

yeah, i noticed that too, not sure what more we can do, any ideas? in the meantime, merge?

simontegg commented 9 years ago

I think the multiple clip-paths for each node may just overload it? Perhaps extract the node sizes, then create just a few clip-paths?

ahdinosaur commented 9 years ago

each clip path is specific to each node, as it includes position as well as size, so we can't extract general clip paths. also notice if you reload a page in FF, all the initial clip paths will work fine, it's only when you navigate to new routes that some won't work.

simontegg commented 9 years ago

Idea: Its possible we could fix this by simply using html elements instead of svg. Lines and arrows can be drawn with css http://www.monkeyandcrow.com/samples/css_lines/.

This could clear up the hacky bits of using svg with react (and enable fancy context-maintaining transitions between view-states:)