StyleEncoder ignores the attention parameter

hologerry / Attr2Font

[SIGGRAPH 2020] Attribute2Font: Creating Fonts You Want From Attributes

https://hologerry.github.io/Attr2Font/

Other

227 stars 37 forks source link

StyleEncoder ignores the attention parameter #17

Closed chanind closed 2 years ago

chanind commented 3 years ago

The StyleEncoder class takes in a boolean attention param, defaulting to true, but this param is ignored and no attention is ever used: https://github.com/hologerry/Attr2Font/blob/master/model.py#L173

hologerry commented 2 years ago

Yeah, that's true, since we found the attention is not working as we expected, we removed the attention related code. The param is just a placeholder, please ignore it. Thanks.