search

hologram-io / hologram-python

Hologram device-side Python SDK - Send messages to the cloud in just 3 lines of code!
https://hologram.io/
MIT License
89 stars 47 forks source link

Upgrade to python 3 #14

Closed tgsoverly closed 4 years ago

tgsoverly commented 4 years ago

Opening this PR for visibility to the developers. Should not be that hard to take this over the finish line.

https://community.hologram.io/t/hologram-sdk-on-python-3-6-5/1860/14

  1. Decompiled an imported the HologramAuth library.
  2. Ran it through 2to3
  3. Fixed tests
DomAmato commented 4 years ago

Sorry there is a lot of issues with this where we cannot accept it. There is a reason the auth module was separate and you added an MIT license on software you don't own/didn't write. We appreciate the nudge but as a developer can you please remove that repo from your account. We are working on this literally this week and it should be ready soon.

tgsoverly commented 4 years ago

@DomAmato FYI I didn't add the MIT license: https://pypi.org/project/python-sdk-auth/ . Per that site it was published under the MIT license. 🤷‍♂ Might want to me more careful with that in the future. I see that it has my name, that was a mistake from the decompile, but the license was existing.

DomAmato commented 4 years ago

🤦‍♂ well thats definitely our bad regarding that.

Regarding the changes, its not quite as easy as changing to python 3 syntax, the tests might pass but the modem will not respond correctly to unicode strings vs byte arrays with the way python3 handles strings. I apologize this migration has taken this long that this even became a thing.

We are in that phase right now making sure all the commands run and work with the modems like we expect. Look for releases in the next few days of both the sdk and the auth library.