search

holography / holograph

Holograph parses the comments in your CSS and turns them into a beautiful style guide.
MIT License
8 stars 3 forks source link

Feature/allow js config #43

Closed Chapabu closed 7 years ago

Chapabu commented 7 years ago

This PR covers #41, and adds a small refactor on the binary to cover the changes.

It allows for YAML to also be parsed, so it's not a breaking change. It also removes the requirement for a Gulp plugin if using the JS config file, which should probably (?) be the recommended approach?

blongden commented 7 years ago

Mostly just for my info - but what is typings? Not seen that before.

Chapabu commented 7 years ago

Typings is the Typescript definition manager (https://github.com/typings/typings), but you don't need TypeScript for it to be useful. It adds autocompletion for third party libraries to IDEs that support it.

So I've got a plugin for VSCode that auto installs type definitions when it detects a change in the package.json, and if there are type definitions available, then it downloads them and I get autocompletion for whatever package I just downloaded :)

blongden commented 7 years ago

I'm still not overly convinced on why we need it but merging anyway. It's not a problem to diverge from Hologram - this started as a port of it, but it can go it's own way if need be. Let's keep BC for now and see how it plays out.