[Report] grub-mkconfig Produces Error - /etc/default/grub: line 15: syntax error near unexpected token `elif'

[Grimish-ng]

Your Issue:

Unable to generate grub-mkconfig -o yada yada yada
Default /etc/default/grub has my old configuration but its not being utilized on linux-holo

Post update was unable to update with my custom kernel parameters.

Your device's full specs

DMI: ASUSTeK COMPUTER INC. ROG Zephyrus G15 GA503QR_GA503QR/GA503QR, BIOS GA503QR.413 11/03/2021
CPU: Ryzen 5900HS
GPU: Nvidia 3070 Mobile

Your OS version

snapshot20220819.0846

(Only for SteamOS Session loading issues) Have you tried launching gamescope-session from terminal? If yes, provide a log.

yeah pubg crash bhai

Your installation type:

deckperience

Have you updated your installation recently?

Yawwwwww

[theVakhovskeIsTaken]

.....soooooooo

what's the error? Also, use holoiso-grub-update command

[Grimish-ng]

Shit - thanks for that - left the error in the title.

[theVakhovskeIsTaken]

.....soooooooo

what's the error? Also, use holoiso-grub-update command

[Grimish-ng]

holoiso-grub-update produces:
[grimish@ryzenos ~]$ holoiso-grub-update 
cat: /etc/default/grub.pacnew: No such file or directory
/etc/default/grub: line 15: syntax error near unexpected token `elif'
/etc/default/grub: line 15: `elif [[ :$AIR_LIST:="~ :$DEVICENAME:  ]]; then"'
Installing for x86_64-efi platform.
Installation finished. No error reported.
/etc/default/grub: line 15: syntax error near unexpected token `elif'

Is that normal behavior? Should i zap my /etc/default/grub with a 'fresh' one? Of course all pertinent info inserted.

[Grimish-ng]

Here is my grub file:

GRUB_TIMEOUT="5"

# Device specific configs
DEVICENAME="$(cat /sys/devices/virtual/dmi/id/product_name)"
# OXP Devices
OXP_LIST="ONE XPLAYER:ONEXPLAYER 1 T08:ONEXPLAYER 1S A08:ONEXPLAYER 1S T08:ONEXPLAYER mini A07:ONEXPLAYER mini GA72:ONEXPLAYER mini GT72:ONEXPLAYER GUNDAM GA72:ONEXPLAYER 2 ARP23"
# AYANEO AIR Devices
AIR_LIST="AIR:AIR Pro"
# AYANEO Gen 1 Devices
AYA_LIST="Next:Some fucking thing i don't own right now"

# Define default cmdlines for each device family
if [ ${DEVICENAME}="= Win600 ]; then"
GRUB_CMDLINE_LINUX_DEFAULT="video=efifb fbcon=rotate:1 quiet splash loglevel=3 rd.udev.log_priority=3 vt.global_cursor_default=0 loglevel=3 nowatchdog mitigations=off clocksource=tsc tsc=reliable amdgpu.exp_hw_support=1 amd_pstate.shared_mem=1 amd_pstate.enabled=1 amd_iommu=off amdgpu.gttsize=8128 spi_amd.speed_dev=1 audit=0"
elif [[ :$AIR_LIST:="~ :$DEVICENAME:  ]]; then"
GRUB_CMDLINE_LINUX_DEFAULT="video=efifb fbcon=rotate:3 quiet splash loglevel=3 rd.udev.log_priority=3 vt.global_cursor_default=0"
elif [ ${DEVICENAME}="= Jupiter 1 ]; then"
GRUB_CMDLINE_LINUX_DEFAULT="video=efifb fbcon=rotate:1 quiet splash loglevel=3 rd.udev.log_priority=3 vt.global_cursor_default=0"
elif [[ :$OXP_LIST:="~ :$DEVICENAME:  ]]; then"
GRUB_CMDLINE_LINUX_DEFAULT="video=efifb fbcon=rotate:3 quiet splash loglevel=3 rd.udev.log_priority=3 vt.global_cursor_default=0"
else
GRUB_CMDLINE_LINUX_DEFAULT="quiet splash loglevel=3 rd.udev.log_priority=3 vt.global_cursor_default=0"
fi

# Define "breeze" Steam Deck GRUB Theme here
GRUB_THEME="/usr/share/grub/themes/breeze/theme.txt"

GRUB_DEFAULT="Advanced options for SteamOS>SteamOS, with Linux linux-holoiso"
GRUB_SAVEDEFAULT="false"

[Grimish-ng]

Think something happened with grub post_upgrade() but i'm still looking into where it occurred. Think its somewhere on the grub.install https://github.com/theVakhovskeIsTaken/grub-holoiso-pkgbuild/blob/main/grub.install

But uncertain. Until I can figure it out or get some help i'm just stuck using default kernel parameters which ain't no big deal.

[Grimish-ng]

Worked it all out. Compared to your current grub: https://github.com/theVakhovskeIsTaken/grub-holoiso-pkgbuild/blob/main/grub.default

changed the abnormalities. Added my custom stuff. Ran holoiso-grub-update thingy

Got the following:
grimish@ryzenos ~]$ holoiso-grub-update 
cat: /etc/default/grub.pacnew: No such file or directory
Installing for x86_64-efi platform.
Installation finished. No error reported.
Generating grub configuration file ...
Found theme: /usr/share/grub/themes/breeze/theme.txt
Found linux image: /boot/vmlinuz-linux-neptune
Found initrd image: /boot/amd-ucode.img /boot/initramfs-linux-neptune.img
Found fallback initrd image(s) in /boot:  amd-ucode.img initramfs-linux-neptune-fallback.img
Found linux image: /boot/vmlinuz-linux-holoiso
Found initrd image: /boot/amd-ucode.img /boot/initramfs-linux-holoiso.img
Found fallback initrd image(s) in /boot:  amd-ucode.img initramfs-linux-holoiso-fallback.img
Warning: os-prober will not be executed to detect other bootable partitions.
Systems on them will not be added to the GRUB boot configuration.
Check GRUB_DISABLE_OS_PROBER documentation entry.
Adding boot menu entry for UEFI Firmware Settings ...
done

Everything gravy. Closed!

As a side note for everyone else - I used a a flatpak grub-customizer thing to make my life easier and of course in the longrun it made it harder. So if anyone had used that before I suggested double checking the repositories /etc/default/grub file with theirs after an upgrade.