search

holos-aafc / Holos

Open source version of the core algorithms used by the Holos model
Other
22 stars 22 forks source link

Manure input not considered in ICBM module #162

Open L-HEREDIA-LOGIAG opened 3 months ago

L-HEREDIA-LOGIAG commented 3 months ago

Contact Details

ludovic.heredia@logiag.com

Expected Behaviour

'Manure Carbon Input (i_m) (kg year^-1)' output in Excel report not at 0 when manure is applied on the field

Actual Behaviour

This output is at 0, every year no matter the modelling tested.

Describe the Issue & Steps to Reproduce

1.1 Imported 'origine of manure' approach in manure gestion for a field (rangeland(native) crop), for the 2019 to 2023 period 1.2 for 2019 to 2023, Manure type: dairy cattle 1.3 Manure handling system: solid storage(stockpiled) 1.4 Application method: solid spread(no tillage or reduced tillage) 1.5 Amount of manure: 11 000 kg.ha-1 1.6 Defaut manure composition in farm detail checked for this type and handling system 1.7 Next/Next/Next 1.8 In Multiyear Carbon results, Manure carbon input is at 0 for the whole period of time, saem thing in the excel file

2.1 20 dairy cattle modelled, between 2018 and 2024, solid storage(stockpiled) manure option 2.2 Replace 'imported' approach by Livestock. The wheel shows that a fraction of the manure is spread (a few %), and around 28 000 kg C.year-1 are available through stockpile manure 2.3 Lauch analysis, no difference

3.1 Modify 11 000 kg.ha-1 manure by 250 000 kg.ha-1 3.2 Launch analysis, no difference

Error Message

No error message, but an odd behaviour. Or my modelling is wrong somewhere

Holos Version Number

4.0 (last version is automatically downloaded when launched)

Code of Conduct

holos-aafc commented 3 months ago

@L-HEREDIA-LOGIAG Could you please export this farm and send it holos@agr.gc.ca

Thanks

holos-aafc commented 3 months ago

There is a restriction in place that occurs when the user selects "Native Rangeland" as the crop type and has manure applications on that field. Are you able to select an alternative perennial crop type instead of native rangeland? If you select one of the other perennial types this issue should not occur.

This would be a temporary work around to get non-zero manure input amounts for this farm.

I will need to make an update to account for your scenario (and farm location) so that Holos does not report 0s as you noticed.

You will need to press the reload button on the details screen if you change the crop type from native rangeland to some other perennial so that Holos can recalculate the manure inputs