Heading change for Soil C Modelling report columns

holos-aafc / Holos

Open source version of the core algorithms used by the Holos model

Other

22 stars 22 forks source link

Heading change for Soil C Modelling report columns #186

Open sarahp1980 opened 1 month ago

sarahp1980 commented 1 month ago

Feature request.

I think we should change the heading for the following columns in the Multiyear Carbon Modelling report so that it is clearer that they refer to emissions from organic N/manure from user-defined manure application only:

'N2O Direct (Excluding any manure not applied) (kg N2O (ha)^-1)' (column CS)
'N2O-N from Organic Nitrogen (Excluding any manure not applied N2O-N_ONdirect) (kg N2O-N field^-1)' (column CX)
'N2O Indirect (Excluding any manure not applied) (kg N2O (ha)^-1)' (column CZ)
'N2O-N Indirect (Excluding any manure not applied) (kg N2O-N field^-1)'
'N2O from Organic Nitrogen Leaching (Excluding any manure not applied N2O-N_ONleach) (kg N2O-N field^-1)' (column DD)
'N2O from Organic Nitrogen Volatilization (Excluding any manure not applied N2O-N_ONvolatilization) (kg N2O-N field^-1)' (column DG)

Any suggestions on if/how we should should rename these would be appreciated.

Code of Conduct

[X] I agree to follow Holos' Code of Conduct

holos-aafc commented 1 month ago

@y-at did you want to start with a suggestion for the wording?

y-at commented 1 month ago

Here's my idea to possibly better convey how these values are affected by user defined parameters. For points 1, 3, and 4 I changed it to state that value excludes manure not applied to fields which can imply the user has the ability to effect the values based on how much manure is being applied. I'm unsure how to rewrite points 2, 5, and 6 right now, would it make sense for them to use a similar format?

'N2O Direct (Excludes manure not applied to fields) (kg N2O (ha)^-1)' (column CS)
'N2O-N from Organic Nitrogen (Excluding any manure not applied N2O-N_ONdirect) (kg N2O-N field^-1)' (column CX)
'N2O Indirect (Excludes manure not applied to fields) (kg N2O (ha)^-1)' (column CZ)
'N2O-N Indirect (Excludes manure not applied to fields) (kg N2O-N field^-1)'
'N2O from Organic Nitrogen Leaching (Excluding any manure not applied N2O-N_ONleach) (kg N2O-N field^-1)' (column DD)
'N2O from Organic Nitrogen Volatilization (Excluding any manure not applied N2O-N_ONvolatilization) (kg N2O-N field^-1)' (column DG)

sarahp1980 commented 2 weeks ago

Thanks for your suggestions Wyatt. Whatever change in wording we adopt for points 1, 3 and 4, I think we can adopt the same change for points 2, 5 and 6. My suggestion in all cases would be to change "Excluding any manure not applied" to "User-defined manure application only" - this is still very long, but at least in my mind this makes it clearer that these emissions estimates relate only to the manure application events specified by the user. We could then also consider renaming the adjacent columns, that include emissions estimates for both user-defined manure and leftover manure application as "All manure applications (incl. leftover manure)"; again, this makes the column heading even longer but hopefully clearer? Another option would be to add a glossary of column headings to GitHub - maybe in the FAQ - that explains in more detail each of the columns in the various results reports.

RKroebel commented 2 weeks ago

?N2O Direct UMao (kg N2O (ha)^-1)? - that is shorter, but also makes it more cryptic, but maybe that is why folks would pay attention?

holos-aafc commented 2 weeks ago

I like the glossary approach. This could be something we add to the user guide. @y-at can you start a new section and format some kind of markdown table template (first column has the heading from the report, second has the description). I will then go in and fill in this table with the definitions