search

holos-aafc / Holos

Open source version of the core algorithms used by the Holos model
Other
22 stars 22 forks source link

Inconsistent parameter between GitHub and Holos - Silage crops #202

Open TVyrns opened 1 day ago

TVyrns commented 1 day ago

Contact Details

tessa.veyrunes@logiag.com

Expected Behaviour

The value "PercentageOfProductYieldReturnedToSoilForSilageCrops" is 35 according to GitHub, but 2 on Holos. Which value is right for silage crops ?

Actual Behaviour

No response

Describe the Issue & Steps to Reproduce

Some variables depend on this parameter, and this has an impact on the entire calculation.

Error Message

no error message

Holos Version Number

4.0.1.2

Code of Conduct

holos-aafc commented 1 day ago

Hi @TVyrns the two values have now be synchronized. The correct value is 2% (the 35% was not used in any situation and was only kept in for backward compatibility with older farm data files).

https://github.com/holos-aafc/Holos/commit/954b595055e58a5833060c963f229a4896974e8c