holos-aafc / Holos

Open source version of the core algorithms used by the Holos model
Other
22 stars 23 forks source link

Eq. 4.3.1-8: indoor barn temperature for ATAfeedlot calculation #203

Closed sarahp1980 closed 2 weeks ago

sarahp1980 commented 2 weeks ago

Contact Details

sarahpogue@gmail.com

Expected Behaviour

I expect Eq. 4.3.1-8 to use the indoor dairy barn temp data when calculating ATAfeedlot, but it appears to be using the outdoor ambient temperature from NASA instead. Can you please confirm that Holos is using the indoor barn temperature data in Table 63 when calculating ATAfeedlot (for housing NH3-N emissions) for all indoor dairy cattle housing systems (i.e., tie-stall, free-stall, milking parlour). For the same equation, Holos should use the outdoor NASA temp data for all outdoor housing, i.e., drylot or exercise yard for dairy cattle and confined no barn (feedlot) for beef cattle.

Please find attached the test Holos farm file and the corresponding Excel version of the calculations for the same farm setup - see rows 61-79 in the "Summary_Solid_LiquidIndirectN2O" worksheet in the "HolosV4ModelTesting_DairyCattle AllEstimates_CURRENT.xlsx" file attached, and column O in the "SolidIndirN2O_LactatingDryCows" worksheet (which uses the Table 63 temp data).

HolosV4ModelTestingDairyCattle AllEstimates_CURRENT.xlsx

HolosV4ModelTesting_Dairy_SolidManure.json

Actual Behaviour

No response

Describe the Issue & Steps to Reproduce

  1. Open attached farm file and click through to the Results > Manure Management Report > Housing NH3-N emissions
  2. Compare the Housing NH3-N emissions estimates from Holos with the corresponding estimate in the Excel file (rows 61-79 in the "Summary_Solid_LiquidIndirectN2O" worksheet and column O in the "SolidIndirN2O_LactatingDryCows" worksheet (which uses the Table 63 temp data).

Error Message

No response

Holos Version Number

4.0.1.1

Code of Conduct

holos-aafc commented 2 weeks ago

Will be fixed in version 4.0.1.5. Indoor dairy housing no longer gets an additional +2 degrees added to indoor temperatures