Skipping possible SyntaxErrors while thumbnailing

holoviz-dev / nbsite

Build a tested, sphinx-based website from notebooks

https://nbsite.holoviz.org

BSD 3-Clause "New" or "Revised" License

28 stars 13 forks source link

Skipping possible SyntaxErrors while thumbnailing #160

Closed jlstevens closed 4 years ago

jlstevens commented 4 years ago

A cell ending in a semicolon would cause a SyntaxError using the current approach. This PR aims to skip these cases (which is fine as a semicolon suppresses display output anyway) safely using eval.

Note: not yet tested!

jlstevens commented 4 years ago

I'll go ahead and merge and immediately tag a dev release to test with examples.pyviz