search

holoviz-dev / nbsite

Build a tested, sphinx-based website from notebooks
https://nbsite.pyviz.org
BSD 3-Clause "New" or "Revised" License
28 stars 13 forks source link

Update to nbconvert 6 (nbclient) #189

Closed ceball closed 1 year ago

ceball commented 3 years ago

We're on 5 for now (#187).

It's probably easy, but a better investment of time might be figuring out if parts of nbsite can be replaced internally by an alternative tool (#2, #174) or if it can be replaced entirely (#68).

maximlt commented 2 years ago

@philippjfr I'd like to update nbsite to support nbconvert 6 (and maybe even 7 since it has release candidates, but one thing at a time).

Do you know why ExecutePreprocessor had to be subclassed? Asking you since apparently you overwrote handle_comm_msg.

https://github.com/pyviz-dev/nbsite/blob/fe2cded1cfc3519b6c423cd55f52ebc044fabb91/nbsite/nbbuild.py#L62-L87

philippjfr commented 2 years ago

We were getting weird errors about the comm being broken for any pyviz_comms based output afaik. Might be possible to fix that to replace the jupyter comm with the Comm baseclass when building the docs I suppose.