search

holoviz-dev / nbsite

Build a tested, sphinx-based website from notebooks
https://nbsite.pyviz.org
BSD 3-Clause "New" or "Revised" License
28 stars 13 forks source link

Compatibility with Bokeh 3.4 #300

Closed hoxbro closed 7 months ago

hoxbro commented 7 months ago

Getting the following error when running the doc build with Bokeh 3.4

 TypeError: argument of type 'URL' is not iterable
Process Process-567:
Traceback (most recent call last):
  File "/Users/runner/miniconda3/envs/test-environment/lib/python3.11/multiprocessing/process.py", line 314, in _bootstrap
    self.run()
  File "/Users/runner/miniconda3/envs/test-environment/lib/python3.11/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/runner/miniconda3/envs/test-environment/lib/python3.11/site-packages/nbsite/pyodide/__init__.py", line 231, in _execution_process
    js, js_exports, js_modules, css, global_exports = extract_extensions(code)
                                                      ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/miniconda3/envs/test-environment/lib/python3.11/site-packages/nbsite/pyodide/__init__.py", line 132, in extract_extensions
    js += [bundle.cdn_url for bundle in extensions if bundle.cdn_url and
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/miniconda3/envs/test-environment/lib/python3.11/site-packages/nbsite/pyodide/__init__.py", line 133, in <listcomp>
    '@holoviz/panel@' not in bundle.cdn_url]
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument of type 'URL' is not iterable

First observed in https://github.com/holoviz/panel/pull/6369