holoviz-dev / pyctdev

Python packaging Common Tasks for Developers
BSD 3-Clause "New" or "Revised" License
11 stars 2 forks source link

Merge build and runtime deps install commands #102

Closed maximlt closed 1 year ago

maximlt commented 1 year ago

This had two effects:

This PR merges the build and runtime deps install commands into a single command. It might lead to slightly different solve results though.

maximlt commented 1 year ago

Arf no that doesn't quite work actually!

The function _get_setup_metadata tries first to open setup.cfg but will usually fail because the HoloViz projects use setup.py, and then tries to import setup.py to get the install_requires dependencies. In doing so it may encounter some imports needed to run setup.py, like importing pyct, which is one of the build dependencies that hasn't yet been installed.

This could be revisited the day the projects all move to setup.cfg or pyproject.toml.