search

holoviz-dev / pyctdev

Python packaging Common Tasks for Developers
BSD 3-Clause "New" or "Revised" License
10 stars 2 forks source link

Don't install the tests extras by default when running develop_install #82

Closed maximlt closed 2 years ago

maximlt commented 2 years ago

Fixes https://github.com/pyviz-dev/pyctdev/issues/81

I've gone through the process of rebuilding the docs of a few holoviz sites and I see more and more environments failing to solve during their install process (currently hvplot and datashader) (the workflow adopted by pyctdev doesn't really help conda since it first creates an empty environment and then installs packages in that environment in multiple steps). Removing the requirements imposed by the default tests can only help in these situations!

I haven't found any single usage of a bare doit develop_install (I mean without any option) so I don't think this change will break any current CI config.

maximlt commented 2 years ago

Philipp agreed that this could be merged. I don't expect this change to break any of the CI workflows of holoviz, and I don't think anyone else is using pyctdev in their CI. It might break the workflow of a few pyctdev users who somehow had figured out they don't need to specify -o tests to install the tests extras dependencies. I personally realized that only very recently.

maximlt commented 2 years ago

And if it does break one of the holoviz CI workflows, then I'll fix it! 🙃