search

holoviz-topics / EarthML

Tools for working with machine learning in earth science
https://earthml.holoviz.org
BSD 3-Clause "New" or "Revised" License
94 stars 21 forks source link

Add pip as an explicit dependency #94

Open spencermathews opened 5 years ago

spencermathews commented 5 years ago

Creating the earthml conda enviroment according to the installation instructions leads to a warning related to pip:

$ conda env create -f environment.yml
Warning: you have pip-installed dependencies in your environment file, but you do not list pip itself as one of your conda dependencies.  Conda may not use the correct pip to install your packages, and they may end up in the wrong place.  Please add an explicit pip dependency.  I'm adding one for you, but still nagging you.

Including pip in the environment prevents this warning, avoids any ambiguity surrounding pip dependencies, and conforms to the best practices as I interpret them.

spencermathews commented 5 years ago

What's up with those checks anyway? And why should they fail due to such an innocuous change?

jbednar commented 5 years ago

It's presumably due to one of our dependencies having released a new and slightly incompatible version; nothing to do with your change. Any new PR opened now will probably show the same problem...