Closed maximlt closed 7 months ago
The docs build include a pre-process step that creates an assets directory at the repo root which contains:
assets
This is all put together so I believe this is vulnerable to name clashes. E.g. two projects can have in their assets an image with the same name.
This new assets directory is then used by nbsite to correct/fix the links in the built docs (it's all quite complicated :)).
Managing the assets sounds like it was pretty painful to implement (https://github.com/pyviz-dev/nbsite/pull/144, https://github.com/pyviz-topics/examples/pull/53), I'm not happy to revive these unpleasant memories!
This is now fixed.
maximlt
commented
7 months ago maximlt
commented
7 months ago
The docs build include a pre-process step that creates an
assetsdirectory at the repo root which contains:assetsdirectoryThis is all put together so I believe this is vulnerable to name clashes. E.g. two projects can have in their
assetsan image with the same name.This new
assetsdirectory is then used by nbsite to correct/fix the links in the built docs (it's all quite complicated :)).Managing the assets sounds like it was pretty painful to implement (https://github.com/pyviz-dev/nbsite/pull/144, https://github.com/pyviz-topics/examples/pull/53), I'm not happy to revive these unpleasant memories!