holoviz-topics / examples

Visualization-focused examples of using HoloViz for specific topics
https://examples.holoviz.org
Creative Commons Attribution 4.0 International
82 stars 24 forks source link

Glaciers: Modernize example #360

Closed Azaya89 closed 7 months ago

Azaya89 commented 7 months ago
github-actions[bot] commented 7 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

maximlt commented 7 months ago

Ok @Azaya89 I think I prefer the approach where we instantiate the template at the very end only. The other way, with pn.extension(template='...') and .servable(area='main/sidebar') is useful but confuses the story a little too much I find. So please remove these bits of code, to focus on building the template at the very end of the notebook.

Azaya89 commented 7 months ago

Ok @Azaya89 I think I prefer the approach where we instantiate the template at the very end only. The other way, with pn.extension(template='...') and .servable(area='main/sidebar') is useful but confuses the story a little too much I find. So please remove these bits of code, to focus on building the template at the very end of the notebook.

What part of the notebook are you referring to pls?

github-actions[bot] commented 7 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

maximlt commented 7 months ago

Hmm the layout looks a bit weird on the website.

image
Azaya89 commented 7 months ago

Therefore, for examples that deploy an app, could you please share a screenshot/GIF of the app in the PR?

Here's how the app looks like now

glaciers
github-actions[bot] commented 7 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

github-actions[bot] commented 7 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

github-actions[bot] commented 7 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

github-actions[bot] commented 7 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

github-actions[bot] commented 7 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

maximlt commented 7 months ago

I built the site locally and it looks much better, thanks for your last changes. I'll update the branch and merge if the dev site site looks similar.

image
github-actions[bot] commented 7 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).