search

holoviz-topics / examples

Visualization-focused examples of using HoloViz for specific topics
https://examples.holoviz.org
Creative Commons Attribution 4.0 International
82 stars 24 forks source link

[DO NOT MERGE] Isaiah's Dummy example #362

Closed Azaya89 closed 7 months ago

Azaya89 commented 7 months ago

I created a dummy example in order to verify all the steps required in creating a new example project from scratch, per https://examples.holoviz.org/contributing.html#add-a-project

I think the only thing we need to modify in the instructions is explicitly mentioning that the doit commands should be run from the top level of the repository. Otherwise, everything else is clear and straight-forward.

github-actions[bot] commented 7 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

Azaya89 commented 7 months ago

Could you update this example to include a deployable panel app? I.e:

  • the notebook must contain something like <app>.servable()
  • the project YAML must be updated with a new dashboard command and that command must be specified in examples_config.deployments

Done.

droumis commented 7 months ago

Nice work! Do you want to add the suggestion for the instructions to your contributing guide PR?

Azaya89 commented 7 months ago

Nice work! Do you want to add the suggestion for the instructions to your contributing guide PR?

Yes, I will do that tomorrow.

maximlt commented 7 months ago

You did great creating this dummy example! I'm going to close this PR now (we can still re-open it later if need be).