search

holoviz-topics / examples

Visualization-focused examples of using HoloViz for specific topics
https://examples.holoviz.org
Creative Commons Attribution 4.0 International
82 stars 24 forks source link

[DO NOT MERGE] Jason's Dummy Example #368

Open jtao1 opened 6 months ago

jtao1 commented 6 months ago

I started making the dummy example.

ahuang11 commented 6 months ago

Thanks for getting this up!

Based on the checks, clicking details and looking for th error:

image image

I think you need to add a anaconda lock file https://anaconda-project.readthedocs.io/en/latest/user-guide/reference.html#locking-package-versions

Run doit validate_project_lock:olympics
.  validate_project_lock:olympics
TaskError - taskid:validate_project_lock:olympics
PythonAction Error
Traceback (most recent call last):
  File "/usr/share/miniconda3/envs/examples-gallery-manage/lib/python3.10/site-packages/doit/action.py", line 461, in execute
    returned_value = self.py_callable(*self.args, **kwargs)
  File "/home/runner/work/examples/examples/dodo.py", line 1112, in validate_project_lock
    complain(f'Missing {lock_path} file')
  File "/home/runner/work/examples/examples/dodo.py", line [17](https://github.com/holoviz-topics/examples/actions/runs/8209752833/job/22455924229?pr=368#step:7:18)7, in complain
    raise ValidationError(msg)
dodo.ValidationError: Missing olympics/anaconda-project-lock.yml file
ahuang11 commented 6 months ago

I'd also add markdown cells in between each code cell to explain what you're doing in a sentence or why.

github-actions[bot] commented 6 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

ahuang11 commented 6 months ago

Code-wise, looks mostly good to me! I don't think I really know how to review the anaconda-project stuff, maybe Maxime or Demetris can help with that?

Maybe write a blog post off this if this doesn't get merged (or do so regardless). I'd also love to see a brief mention of using hvPlot as an exploratory tool then mention hvPlot can be used as an explanatory tool too

Lastly, personally, I'd like to attach screenshots in PRs to help reviewers get a visual pic of the code!

ahuang11 commented 6 months ago

For olympics/thumbnails/olympics.png

maybe use the 100m one instead since it's more interesting.

image
jtao1 commented 6 months ago

The blog post idea sounds great, I'll be sure to do that.

github-actions[bot] commented 6 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

droumis commented 6 months ago

Great work so far @jtao1 ! Can you add a bit of a summary in the PR's description and maybe even a screenshot? Maybe this will evolve into a new example later on and it will help to have an efficient and visual summary.

maximlt commented 6 months ago

@jtao1 can you please clear the notebook off its outputs?