holoviz-topics / examples

Visualization-focused examples using HoloViz for specific topics
https://examples.holoviz.org
Creative Commons Attribution 4.0 International
84 stars 25 forks source link

Modernize notebook: opensky #396

Closed Azaya89 closed 1 week ago

Azaya89 commented 6 months ago

Modernizing an example checklist

Preliminary checks

Change ‘anaconda-project.yml’ to use the latest workable version of packages

Plot API updates (discussed on a per-example basis)

Interactivity API updates (discussed on a per-example basis)

Panel App updates (discussed on a per-example basis)

General code quality updates

Text content

Visual appearance - Example

Visual appearance - Gallery

Workflow (after you have made the changes above)

github-actions[bot] commented 6 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

github-actions[bot] commented 5 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

maximlt commented 5 months ago

Hey @Azaya89, you ticked the first item in the checklist. Did you see this issue https://github.com/holoviz-topics/examples/issues/112? If not, please comment on it.

github-actions[bot] commented 5 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

droumis commented 5 months ago

@Azaya89 can you please click 'resolve conversation' for any comment that is resolved?

Azaya89 commented 5 months ago

@Azaya89 can you please click 'resolve conversation' for any comment that is resolved?

Sure, I'll do that after I push the update, to avoid any confusion in case I click 'resolve' and you can't see it resolved in the PR.

github-actions[bot] commented 1 month ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

github-actions[bot] commented 3 weeks ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

Azaya89 commented 3 weeks ago

I think the only Issue now is the color disparity? @maximlt

github-actions[bot] commented 1 week ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.

Azaya89 commented 1 week ago

Implemented all the fixes and I think it looks good now @maximlt

maximlt commented 1 week ago

Implemented all the fixes and I think it looks good now @maximlt

@Azaya89 thanks for the changes. I've just pushed some minor changes:

Can you please review these changes?

github-actions[bot] commented 1 week ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR.