search

holoviz-topics / examples

Visualization-focused examples using HoloViz for specific topics
https://examples.holoviz.org
Creative Commons Attribution 4.0 International
84 stars 25 forks source link

Validate that notebook<7 is used #397

Closed maximlt closed 5 months ago

maximlt commented 5 months ago

The Workbench platform doesn't yet support deploying read-only notebooks from environments that use notebook v7 or greater. This PR adds a validation step that ensures that a project that declares such a deployment locks to a previous version of notebook.

github-actions[bot] commented 5 months ago

Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/. You can also download an archive of the site from the workflow summary page which comes in handy when your dev site built was overriden by another PR (we have a single dev site!).

Azaya89 commented 5 months ago

I dunno if this brings us back but what Workbench platform problem is this PR avoiding? 'Cos I was having no issues locally building the docs from my updated notebooks @maximlt

maximlt commented 5 months ago

Yes this is unrelated to building the docs, instead, it's related to deploying a read-only notebook, like for example https://boids-notebook.holoviz-demo.anaconda.com/notebooks/boids.ipynb. Making such a deployment isn't part of the test suite, it only happens after we merge a PR, so you don't know whether the deployment fails, unless you check these Github workflows https://github.com/holoviz-topics/examples/actions/workflows/deploy.yml.

Azaya89 commented 5 months ago

OK. Thanks for the clarification!