holoviz-topics / examples

Visualization-focused examples using HoloViz for specific topics
https://examples.holoviz.org
Creative Commons Attribution 4.0 International
84 stars 25 forks source link

Multichannel Timeseries: don't rely on custom downloads #448

Open maximlt opened 6 days ago

maximlt commented 6 days ago

For reasons unrelated to examples.holoviz.org (see https://github.com/holoviz-topics/examples/pull/418#discussion_r1847559977), @droumis has implemented inlined downloads (via pooch) on top of anaconda-project downloads for the Multichannel Timeseries example. I would prefer not to include that sort of code, we cannot guarantee users they will be able to run the notebooks in any other way than via anaconda-project. It's not that I have a passion for this tool, it's just that this whole project is too big to offer custom runtime for each and every example.

droumis commented 5 days ago

Multichannel Timeseries: don't rely on custom downloads #448

I don't think this title is a fair assessment of the situation. The example does not "rely" on custom downloads. Before this issue was created, the example was already using anaconda-project for all the data downloads. The only extra layer is that in the notebook, there is a check if the data is downloaded to the location that anaconda-project should download the data to, and if the data is not present, it uses pooch to do so.

droumis commented 5 days ago

My solution ensures that a user does not require anaconda-project, but anaconda-project is still the encouraged method of running the project, per the website's instructions.