search

holoviz-topics / imagen

ImaGen: Generic Python library for 0D, 1D and 2D pattern distributions
https://imagen.holoviz.org/
BSD 3-Clause "New" or "Revised" License
31 stars 16 forks source link

Added NumpyFile array reader and tests on scale and offset in PatternGenerator #17

Closed mjabri closed 11 years ago

mjabri commented 11 years ago

Added NumpyFile array reader Added tests on scale and offset in PatternGenerator's call before doings ops.

jbednar commented 11 years ago

I've merged the imagen pull request and made some changes; please verify that it still works. In particular, I changed the pattern_sampler so that it wasn't being overwritten in the constructor; previously no one would have been able to supply their own pattern_sampler or change any of its parameters until after the NumpyFile object is created, which is awkward and would have been surprising (i.e. seem to be a bug) in certain cases. The new version should work the same for anything the old one would have done, but please verify that.

The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336.

mjabri commented 11 years ago

Tested with what I was doing and it seems to be working as I expected. Thanks.