search

holoviz-topics / imagen

ImaGen: Generic Python library for 0D, 1D and 2D pattern distributions
https://imagen.holoviz.org/
BSD 3-Clause "New" or "Revised" License
31 stars 16 forks source link

Added support for NChannelImage pattern and ExtendToNChannel patterngene... #28

Closed spiglerg closed 10 years ago

jlstevens commented 10 years ago

Why do you keep closing then re-opening the same pull request? If you simply update the fork you are proposing to merge, the pull request will automatically be updated. No need to create a new one!

EDIT1: Maybe it is because you are trying to merge from "unkown repository". Why don't you fork imagen to your own personal GitHub account and work from there?

EDIT2: Could you also supply better commit messages than just 'fixes'? This makes it hard to tell which commit Travis is testing. In addition, Travis doesn't seem to have picked up on your latest commits so I can't tell is the tests are passing or not.

spiglerg commented 10 years ago

Oh ok. I've just created the pull requests and noticed there were compiling errors. I didn't want them to be integrated into the repository before fixing. :P

G

On Wed, Jul 9, 2014 at 6:46 PM, J.L Stevens notifications@github.com wrote:

Why do you keep closing then re-opening the same pull request? If you simply update the fork you are proposing to merge, the pull request will automatically be updated. No need to create a new one!

— Reply to this email directly or view it on GitHub https://github.com/ioam/imagen/pull/28#issuecomment-48509148.

jlstevens commented 10 years ago

We won't merge until the tests are passing so no need to keep making new pull requests like this!

spiglerg commented 10 years ago

Hmm ok! Now it should work, anyway. ;)

On Wed, Jul 9, 2014 at 6:55 PM, J.L Stevens notifications@github.com wrote:

We won't merge until the tests are passing so no need to keep making new pull requests like this!

— Reply to this email directly or view it on GitHub https://github.com/ioam/imagen/pull/28#issuecomment-48510342.

spiglerg commented 10 years ago

Hmm I did use a personal repository, but only for initiating the pull request, then I closed it. Maybe that's why it's not compiling now? I'm not too used to making pull requests, sorry for the troubles. :/

spiglerg commented 10 years ago

As for the "fixes" you're right, but all the last commits were just changing 1-2 lines to fix the compiling issues, while the only real addition in the pull request are the ExtendToNChannel and NChannelGeneratorSheet objects.

spiglerg commented 10 years ago

Ok, don't hate me, I'm closing this for the last time, and then I'll only modify my fork. :/ This should hopefully fix the Travis tests, I think.

jlstevens commented 10 years ago

Ok. Don't worry - it takes a little while to get used to the GitHub way of doing things!

spiglerg commented 10 years ago

:)

On Wed, Jul 9, 2014 at 7:25 PM, J.L Stevens notifications@github.com wrote:

Ok. Don't worry - it takes a little while to get used to the GitHub way of doing things!

— Reply to this email directly or view it on GitHub https://github.com/ioam/imagen/pull/28#issuecomment-48514233.

jbednar commented 10 years ago
From: spiglerg Date: Jul 9 10:53:51 2014 -0700
Oh ok. I've just created the pull requests and noticed there were compiling
errors. I didn't want them to be integrated into the repository before
fixing. :P

In that case, you can just put a comment on the pull request saying what you're still working on and that it's not yet ready to merge, and no one will merge it yet...

Jim

The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336.