search

holoviz-topics / imagen

ImaGen: Generic Python library for 0D, 1D and 2D pattern distributions
https://imagen.holoviz.org/
BSD 3-Clause "New" or "Revised" License
31 stars 16 forks source link

Update nbs #51

Closed jbednar closed 7 years ago

jbednar commented 7 years ago

The notebooks were from a much older Jupyter version, and need to be converted to work with current ones, so I first updated those, which changed lots of lines of the files due to how Jupyter has changed over time.

Next, there were a few updates to HoloViews since then, including notebook_extension() and hv.Layout() now supporting lists so that the obscure np.sum() trick is no longer needed. It being no longer needed is good, because it seems to hang in some cases that have been difficult to pin down, so this PR also fixes that problem. Should be good to go for hv 1.7.0 after this.

jlstevens commented 7 years ago

I checked out your branch and ran the two notebooks. All seems fine!

I'll merge this PR now but we still need to fix nosetests before releasing.