search

holoviz / colorcet

A set of useful perceptually uniform colormaps for plotting scientific data
http://colorcet.holoviz.org
Other
682 stars 52 forks source link

License in repository is CC-BY, but website says BSD #109

Closed lcniel closed 1 year ago

lcniel commented 1 year ago

I was doing due diligence for the packages I'm planning to install by default in my software, and I noticed that the LICENSE.txt file and about.rst state that colorcet is licensed under CC-BY 3.0 whereas the About page of colorcet.holoviz.org states BSD. It would be good if this divergence was resolved, perhaps a documentation build job just needs to be run or similar? I'm mainly a GitLab user, so I'm not entirely sure.

jbednar commented 1 year ago

Good point! Happy to accept a PR to fix the About page.

lcniel commented 1 year ago

Good point! Happy to accept a PR to fix the About page.

It's not actually clear to me what the exact issue is but the about.rst is aligned with the repo LICENSE. It looks however that it's not being deployed to the website (deploy_dev and deploy_main are not being triggered when I look at recent jobs). Perhaps there is some issue with the docs.yaml? Not familiar enough with the inner workings github workflows or the project to fix quickly myself, unfortunately.

jbednar commented 1 year ago

Oops; should have read your message more closely. The website build is only published for releases, not for scheduled testing jobs, and there hasn't been a release since that was fixed in the source. @maximlt , I don't see an explicit workflow action in colorcet to trigger to force a build out of band; can you add one as we have for other projects?

maximlt commented 1 year ago

It's already there.

image
jbednar commented 1 year ago

Ah, I was looking for it in All Workflows:

image

Sorry for the noise. I've built the site to main; hope it works!

lcniel commented 1 year ago

Looks good to me, thanks for the quick action!

jbednar commented 1 year ago

No problem, and thanks for letting us know!