holoviz / colorcet

A set of useful perceptually uniform colormaps for plotting scientific data
http://colorcet.holoviz.org
Other
673 stars 52 forks source link

Support Python 3.12 #115

Closed bersbersbers closed 4 months ago

bersbersbers commented 8 months ago

Closes #114

jbednar commented 8 months ago

Hmm. Python 3.12 is available on the main conda channel, but it looks like something else isn't yet? Not sure...

bersbersbers commented 8 months ago

I have never used (ana)conda, so its' hard for me to say.

This does not even look like a conflict to me:

Package python conflicts for:
pyctdev -> cloudpickle -> python[version='>=2.7,<2.8.0a0|>=3|>=3.10,<3.11.0a0|>=3.11,<3.12.0a0|>=3.9,<3.10.0a0|>=3.8,<3.9.0a0|>=3.6|>=3.5|>=3.7,<3.8.0a0|>=3.6,<3.7.0a0|>=3.5,<3.6.0a0|>=3.12,<3.13.0a0']
pyctdev -> python[version='>=2.7']
python=3.12

Maybe https://github.com/conda/conda/issues/13072#issuecomment-1745146983?

bersbersbers commented 7 months ago

Would it make sense to simply retry this one?

Edit: My rationale is that after reading https://stackoverflow.com/a/69137255/880783, I am convinced that the reported conflict is not a conflict at all; and after reading https://stackoverflow.com/a/69922162/880783 (and https://github.com/conda/conda/issues/13072#issuecomment-1745146983) I find it likely that some package binary just wasn't made available for Python yet, and I give it good chances that that has changed in the meantime.

Edit2: In fact, py312 files for pyct (https://anaconda.org/anaconda/pyct/files) have only been added in November, after our last run.

So, yes, @jbednar, if you could please kick off CI again, please? :)

jbednar commented 7 months ago

Alas, not successful yet!

maximlt commented 7 months ago

pyctdev has conda-build as a dependency (when installed from conda) and conda-build has not yet been built for Python 3.12 (on defaults, but also on conda-forge which is unusual).

Probably to work around that, and other packages not available yet for Python 3.12, Simon added a special job for running the tests on Python 3.12 using pip only to some of the HoloViz packages, like hvPlot.

@jbednar would you be fine if colorcet's infrastructure was no longer depending on conda at all? It has a pretty simple set of dependencies to install. It's already the case for Param, and I just saw that it's also the case for HoloNote.

jbednar commented 7 months ago

Sure, that would be fine. There shouldn't be any special dependency relationships that would require conda!

bersbersbers commented 5 months ago

Now that 3.12 passes, 3.7 fails 🤪

bersbersbers commented 4 months ago

Obsoleted by #120.