holoviz / colorcet

A set of useful perceptually uniform colormaps for plotting scientific data
http://colorcet.holoviz.org
Other
673 stars 52 forks source link

Simplify dev tooling, remove `colorcet examples`, drop 3.7, add 3.12 #120

Closed maximlt closed 4 months ago

maximlt commented 4 months ago

Colorcet is a simple package, its dev tooling and infra can be simplified. Principles adopted:

As a consequence:

I removed the colorcet examples CLI as it was one less thing to migrate moving from setup.py to pyproject.toml. I guess I could add it again if we want to keep it, although it's a bit annoying as I also moved all the notebook files from /examples to /doc to build with Sphinx directly. Note that Panel removed panel examples is version 1.0.

I thought about moving to hatch/hatchling too in this PR but stuck to setuptools for now, it made my life easier. But from this point on it should be pretty easy to convert to hatch/hatchling if need be.

A change I noticed is that now the sdist has all the tracked files in the repository while it contained less files. This is because setuptools_scm provide a list of all tracked files to setuptools. It could be reduced by pruning dirs and files in MANIFEST.in. I don't see a need to do that.

EDIT:

Happy to report that all the three Github workflows are working with this setup. Also, for some reason I had to update a couple of base images in https://github.com/holoviz/colorcet/pull/120/commits/012124efc27dbeb2a0e42790f87e2f70085182ba. The diff shows that it had something to do with the font more than with the palette.

result-failed-diff result-failed-diff2

maximlt commented 4 months ago

@jbednar are you ok to merge?