holoviz / colorcet

A set of useful perceptually uniform colormaps for plotting scientific data

http://colorcet.holoviz.org

Other

682 stars 52 forks source link

Add support for Python 3.10 #81

Closed maximlt closed 2 years ago

maximlt commented 2 years ago

[x] Check that the tests pass on 3.10
[x] Have a look at potential warnings and update the code if need be

maximlt commented 2 years ago

Oh so all the tests are failing and this is not due to the changes brought by this PR. Investigating why.

maximlt commented 2 years ago

Ok so my bad! The change I recently made to pyctdev not to install the tests dependencies by default actually affected colorcet's CI. The fix is simple though, just adding -o tests.

maximlt commented 2 years ago

However now the tests are still failing. Two images don't compare, I'm running the tests locally to see how they differ.

codecov-commenter commented 2 years ago

Codecov Report

Merging #81 (9b7dedf) into master (0a7bf7b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files           7        7           
  Lines        1579     1579           
=======================================
  Hits         1513     1513           
  Misses         66       66

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a7bf7b...9b7dedf. Read the comment docs.

maximlt commented 2 years ago

Even though the CI is currently failing (except on Python 2.7) it's actually in a good state. It should pass again after the next release of Holoviews, whose previous one broke a couple of colorcet tests.

Having the CI running on Python 3.6 to Python 3.10 was more challenging than expected. The solutions that helped:

Updating conda, except on Python 3.6
Avoiding to run doit env_create as it has a step (install pyctdev) whose channels can't be configured as much as we'd like (only one channel can be used, passed as an environment variable, otherwise it's pyviz by default). This led to errors on Python 3.10. It can easily be replaced by conda create -n ... -c ... python=... pyctev

maximlt commented 2 years ago

Let's run these jobs again once holoviews is released.

maximlt commented 2 years ago

All green, this is ready for me @jbednar

jbednar commented 2 years ago

Thanks, @maximlt !!!