search

holoviz / datashader

Quickly and accurately render even the largest data.
http://datashader.org
BSD 3-Clause "New" or "Revised" License
3.3k stars 365 forks source link

Better validate canvas.line() coordinate lengths #1160

Closed ianthomas23 closed 1 year ago

ianthomas23 commented 1 year ago

Fixes #1159.

This adds extra checks in the validate() functions of the various line classes such as LinesAxis1XConstant to check that the supplied x and y coordinates have the same lengths.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1160 (bebd8ee) into main (a1d9513) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1160      +/-   ##
==========================================
+ Coverage   85.38%   85.39%   +0.01%     
==========================================
  Files          35       35              
  Lines        7812     7820       +8     
==========================================
+ Hits         6670     6678       +8     
  Misses       1142     1142
Impacted Files Coverage Δ
datashader/glyphs/line.py 92.85% <100.00%> (+0.05%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ianthomas23 commented 1 year ago

I am merging this following review approval. There is a CI problem with Python 3.7 on macos but that is affecting all PRs and I will address it as soon as possible.