search

holoviz / datashader

Quickly and accurately render even the largest data.
http://datashader.org
BSD 3-Clause "New" or "Revised" License
3.3k stars 365 forks source link

nopython=True everywhere #1162

Closed ianthomas23 closed 1 year ago

ianthomas23 commented 1 year ago

This PR forces all use of numba.jit to be in nopython=True mode, as recommended by numba maintainer @stuartarchibald. The changes only affect the edge bundling code.

Test suite passes locally on CPU and GPU.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1162 (edd0e8b) into main (8f66c5e) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
- Coverage   85.39%   85.39%   -0.01%     
==========================================
  Files          35       35              
  Lines        7820     7819       -1     
==========================================
- Hits         6678     6677       -1     
  Misses       1142     1142
Impacted Files Coverage Δ
datashader/bundling.py 98.62% <100.00%> (-0.01%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more