holoviz / datashader

Quickly and accurately render even the largest data.
http://datashader.org
BSD 3-Clause "New" or "Revised" License
3.3k stars 365 forks source link

Add check to see if cmap is a tuple of hex values #1173

Closed hoxbro closed 1 year ago

hoxbro commented 1 year ago

The problem was first observed here https://github.com/holoviz/holoviews/pull/5607

Todo

codecov[bot] commented 1 year ago

Codecov Report

Merging #1173 (08ff7b0) into main (35fff08) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1173   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files          35       35           
  Lines        8008     8010    +2     
=======================================
+ Hits         6836     6838    +2     
  Misses       1172     1172           
Impacted Files Coverage Δ
datashader/transfer_functions/__init__.py 86.86% <100.00%> (+0.04%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ianthomas23 commented 1 year ago

The pip test failures are unrelated.

ianthomas23 commented 1 year ago

Test could go in test_transfer_functions.py near test_shade_cmap() and similar.