Closed ianthomas23 closed 1 year ago
Merging #1180 (4d6e06c) into main (d8167b4) will not change coverage. The diff coverage is
67.69%
.
@@ Coverage Diff @@
## main #1180 +/- ##
=======================================
Coverage 85.38% 85.38%
=======================================
Files 35 35
Lines 8011 8011
=======================================
Hits 6840 6840
Misses 1171 1171
Impacted Files | Coverage Δ | |
---|---|---|
datashader/reductions.py | 85.99% <67.18%> (ø) |
|
datashader/compiler.py | 95.62% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Merging as this passes CI (except for the usual codecov not dealing with CUDA code) and I need it to build on top of.
Recently the various
Reduction._append
functions were changed to return a boolean to indicate if they have performed any modification to theiragg
. This was to support the newwhere
reductions that need to know if theirselector
reduction has modified anything so that they can propagate this to their ownagg
containing e.g. row index. Boolean was fine for that, but with the plan to introduce new 3D aggs such asmax_n
then a boolean is not sufficient as it needs to be the index of change in the final dimension.This PR just changes the return from a boolean to an integer index, to confirm that it does not break anything in CI.
True
is changed to0
, meaning index of0
in the 3rd agg dimension, andFalse
to-1
meaning no change has occurred.